How ?
This analyser searches path between two classes through calls of public
methods, inheritance or instanciation.
The language I used for representing source code into a digraph was
created especially to show that.
Note 1 : This service creates a new digraph by selecting only the class
vertices because with the implementations, there are too many vertices.
The goal of the digraph is the "search for bridges". This is a concept
in graph theory where two highly connected graphs are linked by only one
edge. By cuting this edge (by adding an interface for example), you can
easily break your "monolith of code" into two pieces.
Note 2 : since I only analyse public methods, I knowingly miss some
connections. I state that it is not an issue now. If there is a new
instance in a protected method, this an "inner refactoring" not a refactoring
of the structure of public implementations.
In a second time, you can refactor this coupling later because you have
more freedom to change that : you are in a class, there is no coupling outside,
or perhaps it's ok (factory method pattern for example). Remember, the purpose
of this service is to help you to "break a monolith" you barely know,
not to replace your coding skills. There is no magic for that.
There are more immportant issues with cycles of components for example.
protected function processGraph(Graph $graph, OutputInterface $output)
{
$algo = new SpaghettiCoupling($graph);
$result = new Digraph();
$chosenStrategy = $this->connectionStrategy;
$algo->setFilterPath(new $chosenStrategy($result));
$algo->generateCoupledClassGraph();
if ($this->showCycle) {
$result = new Cycle($result);
}
return $result;
}
/**
* @expectedException \LogicException
*/
public function testStrategySetted()
{
$graph = new SpaghettiCoupling(new Digraph());
$graph->generateCoupledClassGraph();
}