public function buildLinters()
 {
     $linters = array();
     $paths = $this->getPaths();
     foreach ($paths as $key => $path) {
         if (!$this->pathExists($path)) {
             unset($paths[$key]);
         }
         if (preg_match('@^externals/@', $path)) {
             // Third-party stuff lives in /externals/; don't run lint engines
             // against it.
             unset($paths[$key]);
         }
     }
     $generated_linter = new ArcanistGeneratedLinter();
     $linters[] = $generated_linter;
     $nolint_linter = new ArcanistNoLintLinter();
     $linters[] = $nolint_linter;
     $text_linter = new ArcanistTextLinter();
     $linters[] = $text_linter;
     foreach ($paths as $path) {
         $is_text = false;
         if (preg_match('/\\.(php|css|hpp|cpp|l|y)$/', $path)) {
             $is_text = true;
         }
         if ($is_text) {
             $generated_linter->addPath($path);
             $generated_linter->addData($path, $this->loadData($path));
             $nolint_linter->addPath($path);
             $nolint_linter->addData($path, $this->loadData($path));
             $text_linter->addPath($path);
             $text_linter->addData($path, $this->loadData($path));
         }
     }
     $name_linter = new ArcanistFilenameLinter();
     $linters[] = $name_linter;
     foreach ($paths as $path) {
         $name_linter->addPath($path);
     }
     $xhpast_linter = new ArcanistXHPASTLinter();
     $linters[] = $xhpast_linter;
     foreach ($paths as $path) {
         if (preg_match('/\\.php$/', $path)) {
             $xhpast_linter->addPath($path);
             $xhpast_linter->addData($path, $this->loadData($path));
         }
     }
     $linters = array_merge($linters, $this->buildLicenseLinters($paths));
     $linters = array_merge($linters, $this->buildPythonLinters($paths));
     $linters = array_merge($linters, $this->buildJSLinters($paths));
     return $linters;
 }
Beispiel #2
0
 public function buildLinters()
 {
     $linters = array();
     $paths = $this->getPaths();
     // Remove all deleted files, which are not checked by the
     // following linters.
     foreach ($paths as $key => $path) {
         if (!Filesystem::pathExists($this->getFilePathOnDisk($path))) {
             unset($paths[$key]);
         } else {
             foreach (static::$IGNORED_PATH_PATTERNS as $pattern) {
                 if (preg_match($pattern, $path)) {
                     unset($paths[$key]);
                     break;
                 }
             }
         }
     }
     $generated_linter = new ArcanistGeneratedLinter();
     $linters[] = $generated_linter;
     $nolint_linter = new ArcanistNoLintLinter();
     $linters[] = $nolint_linter;
     $license_linter = new WatchmanLicenseLinter();
     $linters[] = $license_linter;
     $text_linter = new ArcanistTextLinter();
     $text_linter->setCustomSeverityMap(array(ArcanistTextLinter::LINT_LINE_WRAP => ArcanistLintSeverity::SEVERITY_ADVICE));
     $linters[] = $text_linter;
     $spelling_linter = new ArcanistSpellingLinter();
     $linters[] = $spelling_linter;
     foreach ($paths as $path) {
         if (preg_match('/\\.(c|php|markdown|h)$/', $path)) {
             $nolint_linter->addPath($path);
             $generated_linter->addPath($path);
             $generated_linter->addData($path, $this->loadData($path));
             $text_linter->addPath($path);
             $text_linter->addData($path, $this->loadData($path));
             $spelling_linter->addPath($path);
             $spelling_linter->addData($path, $this->loadData($path));
         }
         if (preg_match('/\\.(c|h|php)$/', $path)) {
             $license_linter->addPath($path);
             $license_linter->addData($path, $this->loadData($path));
         }
     }
     $name_linter = new ArcanistFilenameLinter();
     $linters[] = $name_linter;
     foreach ($paths as $path) {
         $name_linter->addPath($path);
     }
     return $linters;
 }
Beispiel #3
0
 public function buildLinters()
 {
     $linters = array();
     $paths = $this->getPaths();
     foreach ($paths as $key => $path) {
         // Don't lint third party
         if (preg_match("#^thirdparty/#", $path)) {
             unset($paths[$key]);
         }
         // Remove all deleted files, which are not checked by the
         // following linters.
         if (!Filesystem::pathExists($this->getFilePathOnDisk($path))) {
             unset($paths[$key]);
         }
     }
     $generated_linter = new ArcanistGeneratedLinter();
     $linters[] = $generated_linter;
     $nolint_linter = new ArcanistNoLintLinter();
     $linters[] = $nolint_linter;
     $c_linter = new PhenomCLinter();
     $linters[] = $c_linter;
     $text_linter = new ArcanistTextLinter();
     $text_linter->setCustomSeverityMap(array(ArcanistTextLinter::LINT_LINE_WRAP => ArcanistLintSeverity::SEVERITY_ADVICE));
     $linters[] = $text_linter;
     $spelling_linter = new ArcanistSpellingLinter();
     $linters[] = $spelling_linter;
     foreach ($paths as $path) {
         if (preg_match('/\\.(c|php|markdown|h)$/', $path)) {
             $nolint_linter->addPath($path);
             $generated_linter->addPath($path);
             $generated_linter->addData($path, $this->loadData($path));
             $text_linter->addPath($path);
             $text_linter->addData($path, $this->loadData($path));
             $spelling_linter->addPath($path);
             $spelling_linter->addData($path, $this->loadData($path));
         }
         if (preg_match('/\\.(c|h)$/', $path)) {
             $c_linter->addPath($path);
             $c_linter->addData($path, $this->loadData($path));
         }
     }
     $name_linter = new ArcanistFilenameLinter();
     $linters[] = $name_linter;
     foreach ($paths as $path) {
         $name_linter->addPath($path);
     }
     return $linters;
 }
 public function buildLinters()
 {
     $linters = array();
     $paths = $this->getPaths();
     // This needs to go first so that changes to generated files cause module
     // linting. This linter also operates on removed files, because removing
     // a file changes the static properties of a module.
     $module_linter = new ArcanistPhutilModuleLinter();
     $linters[] = $module_linter;
     foreach ($paths as $path) {
         $module_linter->addPath($path);
     }
     // Remaining lint engines operate on file contents and ignore removed
     // files.
     foreach ($paths as $key => $path) {
         if (!$this->pathExists($path)) {
             unset($paths[$key]);
         }
         if (preg_match('@^externals/@', $path)) {
             // Third-party stuff lives in /externals/; don't run lint engines
             // against it.
             unset($paths[$key]);
         }
     }
     $generated_linter = new ArcanistGeneratedLinter();
     $linters[] = $generated_linter;
     $nolint_linter = new ArcanistNoLintLinter();
     $linters[] = $nolint_linter;
     $text_linter = new ArcanistTextLinter();
     $linters[] = $text_linter;
     foreach ($paths as $path) {
         $is_text = false;
         if (preg_match('/\\.(php|css|hpp|cpp|l|y)$/', $path)) {
             $is_text = true;
         }
         if ($is_text) {
             $generated_linter->addPath($path);
             $generated_linter->addData($path, $this->loadData($path));
             $nolint_linter->addPath($path);
             $nolint_linter->addData($path, $this->loadData($path));
             $text_linter->addPath($path);
             $text_linter->addData($path, $this->loadData($path));
         }
     }
     $name_linter = new ArcanistFilenameLinter();
     $linters[] = $name_linter;
     foreach ($paths as $path) {
         $name_linter->addPath($path);
     }
     $xhpast_linter = new ArcanistXHPASTLinter();
     $linters[] = $xhpast_linter;
     foreach ($paths as $path) {
         if (preg_match('/\\.php$/', $path)) {
             $xhpast_linter->addPath($path);
             $xhpast_linter->addData($path, $this->loadData($path));
         }
     }
     $linters = array_merge($linters, $this->buildLicenseLinters($paths));
     $linters = array_merge($linters, $this->buildPythonLinters($paths));
     $linters = array_merge($linters, $this->buildJSLinters($paths));
     return $linters;
 }
 public function buildLinters()
 {
     $linters = array();
     $paths = $this->getPaths();
     // Remove all deleted files, which are not checked by the
     // following linters.
     foreach ($paths as $key => $path) {
         if (!Filesystem::pathExists($this->getFilePathOnDisk($path))) {
             unset($paths[$key]);
         }
     }
     $generated_linter = new ArcanistGeneratedLinter();
     $linters[] = $generated_linter;
     $nolint_linter = new ArcanistNoLintLinter();
     $linters[] = $nolint_linter;
     $text_linter = new ArcanistTextLinter();
     $text_linter->setCustomSeverityMap(array(ArcanistTextLinter::LINT_LINE_WRAP => ArcanistLintSeverity::SEVERITY_ADVICE));
     $linters[] = $text_linter;
     $java_text_linter = new ArcanistTextLinter();
     $java_text_linter->setMaxLineLength(100);
     $java_text_linter->setCustomSeverityMap(array(ArcanistTextLinter::LINT_LINE_WRAP => ArcanistLintSeverity::SEVERITY_ADVICE));
     $linters[] = $java_text_linter;
     $python_linter = new ArcanistPEP8Linter();
     $linters[] = $python_linter;
     // Currently we can't run cpplint in commit hook mode, because it
     // depends on having access to the working directory.
     if (!$this->getCommitHookMode()) {
         $cpp_linters = array();
         $google_linter = new ArcanistCpplintLinter();
         $cpp_linters[] = $linters[] = $google_linter;
         $cpp_linters[] = $linters[] = new FbcodeCppLinter();
         $cpp_linters[] = $linters[] = new PfffCppLinter();
     }
     $spelling_linter = new ArcanistSpellingLinter();
     $linters[] = $spelling_linter;
     foreach ($paths as $path) {
         $is_text = false;
         $text_extensions = '/\\.(' . 'cpp|cxx|c|cc|h|hpp|hxx|tcc|' . 'py|rb|hs|pl|pm|tw|' . 'php|phpt|css|js|' . 'java|' . 'thrift|' . 'lua|' . 'siv|' . 'txt' . ')$/';
         if (preg_match($text_extensions, $path)) {
             $is_text = true;
         }
         if ($is_text) {
             $nolint_linter->addPath($path);
             $generated_linter->addPath($path);
             $generated_linter->addData($path, $this->loadData($path));
             if (preg_match('/\\.java$/', $path)) {
                 $java_text_linter->addPath($path);
                 $java_text_linter->addData($path, $this->loadData($path));
             } else {
                 $text_linter->addPath($path);
                 $text_linter->addData($path, $this->loadData($path));
             }
             $spelling_linter->addPath($path);
             $spelling_linter->addData($path, $this->loadData($path));
         }
         if (preg_match('/\\.(cpp|c|cc|cxx|h|hh|hpp|hxx|tcc)$/', $path)) {
             foreach ($cpp_linters as &$linter) {
                 $linter->addPath($path);
                 $linter->addData($path, $this->loadData($path));
             }
         }
         // Match *.py and contbuild config files
         if (preg_match('/(\\.(py|tw|smcprops)|^contbuild\\/configs\\/[^\\/]*)$/', $path)) {
             $space_count = 4;
             $real_path = $this->getFilePathOnDisk($path);
             $dir = dirname($real_path);
             do {
                 if (file_exists($dir . '/.python2space')) {
                     $space_count = 2;
                     break;
                 }
                 $dir = dirname($dir);
             } while ($dir != '/' && $dir != '.');
             $cur_path_linter = $python_linter;
             $cur_path_linter->addPath($path);
             $cur_path_linter->addData($path, $this->loadData($path));
             if (preg_match('/\\.tw$/', $path)) {
                 $cur_path_linter->setCustomSeverityMap(array('E251' => ArcanistLintSeverity::SEVERITY_DISABLED));
             }
         }
     }
     $name_linter = new ArcanistFilenameLinter();
     $linters[] = $name_linter;
     foreach ($paths as $path) {
         $name_linter->addPath($path);
     }
     return $linters;
 }
Beispiel #6
0
 public function buildLinters()
 {
     $linters = array();
     $paths = $this->getPaths();
     // This needs to go first so that changes to generated files cause module
     // linting. This linter also operates on removed files, because removing
     // a file changes the static properties of a module.
     $module_linter = new ArcanistPhutilModuleLinter();
     $linters[] = $module_linter;
     foreach ($paths as $path) {
         $module_linter->addPath($path);
     }
     // Remaining lint engines operate on file contents and ignore removed
     // files.
     foreach ($paths as $key => $path) {
         if (!$this->pathExists($path)) {
             unset($paths[$key]);
         }
         if (preg_match('@^externals/@', $path)) {
             // Third-party stuff lives in /externals/; don't run lint engines
             // against it.
             unset($paths[$key]);
         }
     }
     $generated_linter = new ArcanistGeneratedLinter();
     $linters[] = $generated_linter;
     $nolint_linter = new ArcanistNoLintLinter();
     $linters[] = $nolint_linter;
     $text_linter = new ArcanistTextLinter();
     $linters[] = $text_linter;
     $spelling_linter = new ArcanistSpellingLinter();
     $linters[] = $spelling_linter;
     foreach ($paths as $path) {
         $is_text = false;
         if (preg_match('/\\.(php|css|js|hpp|cpp|l|y)$/', $path)) {
             $is_text = true;
         }
         if ($is_text) {
             $generated_linter->addPath($path);
             $generated_linter->addData($path, $this->loadData($path));
             $nolint_linter->addPath($path);
             $nolint_linter->addData($path, $this->loadData($path));
             $text_linter->addPath($path);
             $text_linter->addData($path, $this->loadData($path));
             $spelling_linter->addPath($path);
             $spelling_linter->addData($path, $this->loadData($path));
         }
     }
     $name_linter = new ArcanistFilenameLinter();
     $linters[] = $name_linter;
     foreach ($paths as $path) {
         $name_linter->addPath($path);
     }
     $xhpast_linter = new ArcanistXHPASTLinter();
     $xhpast_linter->setCustomSeverityMap(array(ArcanistXHPASTLinter::LINT_RAGGED_CLASSTREE_EDGE => ArcanistLintSeverity::SEVERITY_WARNING, ArcanistXHPASTLinter::LINT_PHP_53_FEATURES => ArcanistLintSeverity::SEVERITY_ERROR));
     $license_linter = new ArcanistApacheLicenseLinter();
     $linters[] = $xhpast_linter;
     $linters[] = $license_linter;
     foreach ($paths as $path) {
         if (preg_match('/\\.php$/', $path)) {
             $xhpast_linter->addPath($path);
             $xhpast_linter->addData($path, $this->loadData($path));
         }
     }
     foreach ($paths as $path) {
         if (preg_match('/\\.(php|cpp|hpp|l|y)$/', $path)) {
             if (!preg_match('@^externals/@', $path)) {
                 $license_linter->addPath($path);
                 $license_linter->addData($path, $this->loadData($path));
             }
         }
     }
     return $linters;
 }